Skip to content

Comments

update remaining instantiate calls#359

Merged
peverwhee merged 5 commits intoESCOMP:mainfrom
peverwhee:add-diag-name
Feb 13, 2026
Merged

update remaining instantiate calls#359
peverwhee merged 5 commits intoESCOMP:mainfrom
peverwhee:add-diag-name

Conversation

@peverwhee
Copy link
Collaborator

@peverwhee peverwhee commented Jan 20, 2026

Tag name: n/a
Originator(s): peverwhee

Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
Updates remaining instantiate calls for runtime constituents to include the diagnostic name. Needed to update to latest framework tag.

Also adds comments to scheme metadata that has different dependencies depending on whether you're running on CPUs or GPUs.

List all namelist files that were added or changed: n/a

List all files eliminated and why: n/a

List all files added and what they do: n/a

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

M   schemes/rrtmgp/rrtmgp_constituents.F90
M   test/test_schemes/initialize_constituents.F90
- update instantiate calls to include diagnostic name

M   schemes/rrtmgp/objects/ccpp_gas_optics_rrtmgp.meta
M   schemes/rrtmgp/rrtmgp_lw_cloud_optics.meta
M   schemes/rrtmgp/rrtmgp_lw_gas_optics.meta
M   schemes/rrtmgp/rrtmgp_lw_rte.meta
M   schemes/rrtmgp/rrtmgp_sw_gas_optics.meta
M   schemes/rrtmgp/rrtmgp_sw_rte.meta
- add clarifying comments to metadata files that have different dependencies for GPU or CPU configurations

List all automated tests that failed, as well as an explanation for why they weren't fixed: n/a

Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc? b4b

If yes to the above question, describe how this code was validated with the new/modified features:

@peverwhee peverwhee self-assigned this Jan 20, 2026
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peverwhee!

@peverwhee peverwhee merged commit 87e76a6 into ESCOMP:main Feb 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants